search

fmthoma / vgrep

A pager for grep
BSD 3-Clause "New" or "Revised" License
104 stars 8 forks source link

Add compatibility with aeson-1.1 #39

Closed sjakobi closed 7 years ago

fmthoma commented 7 years ago

@sjakobi Thanks for the PR! I have added some review comments, apart from those it looks good (and CI verifies backwards compatibility with aeson-0.9 and aeson-0.11).

sjakobi commented 7 years ago

I have added some review comments

I can't see these?!

fmthoma commented 7 years ago

Right. Because I entered them, but forgot to submit the review :-)

sjakobi commented 7 years ago

@fmthoma: I have added a commit that addresses your comments!

fmthoma commented 7 years ago

Merged. @sjakobi, thank you for yor contribution!

sjakobi commented 7 years ago

Thanks for the discussion and review! This is a much better solution than my first PR!