search

fmtlib / fmt

A modern formatting library
https://fmt.dev
Other
19.84k stars 2.42k forks source link

github: update lint.yml to post details on formatting issue #3988

Closed tchaikov closed 1 month ago

tchaikov commented 1 month ago

before this change, contributers need to click into the "details" link for more details on the formatting issue identified by the lint workflow.

after this change, the workflow pastes the details with a comment, to provide more specific details on the formatting issue if any.

tchaikov commented 1 month ago

for an example of the change in action, see https://github.com/tchaikov/fmt/pull/2#issuecomment-2143917194 . where i updated the tree with clang-fmt 19, and send the formatted tree as a PR. and the workflow pasted the diff as expected. because, apparently, clang-fmt 17 and clang-fmt 19 have different tastes on the formatting.

vitaut commented 1 month ago

This looks great, thank you!