search

fmtlib / fmt

A modern formatting library
https://fmt.dev
Other
19.84k stars 2.42k forks source link

You can (not) control the Unicode support via the CMake `FMT_UNICODE` option. #4051

Closed grooverdan closed 2 days ago

grooverdan commented 3 days ago

version: 11.0.0

It looks like its true, but you can't compile on MSVC without it.

As a subproject the option needs to be enabled for the target_compile_options to be applied.

include/fmt/base.h forces the define to true.

Line 457 will assert if the /utf8 isn't set.

ref: https://buildbot.mariadb.org/#/builders/234/builds/30730/steps/8/logs/stdio

vitaut commented 3 days ago

Thanks for reporting. Just to clarify: are you trying to disable Unicode support? Setting FMT_UNICODE macro was missing from the CMake config which is fixed in https://github.com/fmtlib/fmt/commit/e50c8b6bd870eb743b2cf13850d5aafcf7d1bad8.

grooverdan commented 2 days ago

I just noticed it was there. I'm happy to enable unicode.

vitaut commented 2 days ago

Closing as disabling Unicode has been fixed but if there is more to it please let me know.