search

fn2006 / PollyMC

DRM-free Prism Launcher fork with support for custom auth servers.
GNU General Public License v3.0
824 stars 51 forks source link

Add auth server column to account list #139

Open BatteredBunny opened 8 months ago

BatteredBunny commented 8 months ago

I had a hard time distinguishing accounts with same names in account list so i added an auth server column.

pollymc_account_list

BatteredBunny commented 8 months ago

This is great, could you add

ui->listView->header()->setSectionResizeMode(AccountList::VListColumns::AuthServerColumn, QHeaderView::ResizeToContents);

to launcher/ui/pages/global/AccountListPage.cpp so that the column is auto-resized to fit the URL?

Thank you! Did not know that was an option. Initially i had cut the suffix exactly due to it not fitting in the box.

Also, personally I'd prefer the full authlib-injector URL rather than the authserver URL with the authlib-injector suffix stripped out (and blank for Mojang/MSA/Offline accounts). The reason being that if you wanted to add a new account and copy that URL for the new account, you'd need that full "authlib-injector" endpoint (many servers will work anyway because they send the x-authlib-injector-api-location header, but this is not guaranteed). You'd need to add a getter for authlibInjectorUrl in AccountData.h.

Seems reasonable, will do :)