search

fn2006 / PollyMC

DRM-free Prism Launcher fork with support for custom auth servers.
GNU General Public License v3.0
827 stars 51 forks source link

Ely.by skins don't show up on servers #58

Open Zendevve opened 1 year ago

Zendevve commented 1 year ago

Operating System

Windows

Version of PollyMC

PollyMC 6.3

Version of Qt

Qt 6.3.0

Description of bug

The ely.by skins work perfectly fine on a singleplayer world for me but when i try and join a server (e.g. the one 1.19.2 server i made) it fails to show my ely.by skin but instead reverts back to Steve instead.

I use ely.by on TL Legacy (not TLauncher) and when i link my ely.by account there it works fine on servers? I was wondering if theres a fix to this thank you<3

Steps to reproduce

log in to your ely.by account on the launcher launch the instance you want (i.e. simply optimized 1.19.2 modpack in my case) play a singleplayer world (skin should show up fine) play on server (skin wont show up and be steve)

Suspected cause

honestly no idea sadly

This issue is unique

lemonzest79 commented 1 year ago

Working fine here, did you start your server with authlib-injector??

2023-03-31_06 05 51

Personal 1.12.2 Server, skins also fine on my 1.19.3 Server, both started with authlib-injector 1.2.2 but also worked with 1.2.1

Zendevve commented 1 year ago

Working fine here, did you start your server with authlib-injector??

2023-03-31_06 05 51

Personal 1.12.2 Server, skins also fine on my 1.19.3 Server, both started with authlib-injector 1.2.2 but also worked with 1.2.1

how exactly do i do that? i am unfamiliar with this authlib injector :< do you have discord so we can talk more about it there?

lemonzest79 commented 1 year ago

Server needs starting as online and with this "java -javaagent:authlib-injector-1.2.2.jar=ely.by -jar server.jar" or if its modded just add "-javaagent:authlib-injector-1.2.2.jar=ely.by" to its launch script then log into it with your ely.by account on the launcher, not really wanting to give out my discord publically.

https://github.com/yushijinhun/authlib-injector/releases

Place this next to your server.jar

Zendevve commented 1 year ago

-javaagent:authlib-injector-1.2.2.jar=ely.by

alright i'll give it a shot thanks

Zendevve commented 1 year ago

Server needs starting as online and with this "java -javaagent:authlib-injector-1.2.2.jar=ely.by -jar server.jar" or if its modded just add "-javaagent:authlib-injector-1.2.2.jar=ely.by" to its launch script then log into it with your ely.by account on the launcher, not really wanting to give out my discord publically.

https://github.com/yushijinhun/authlib-injector/releases

Place this next to your server.jar

no idea how to do this on falixnodes

dzmtrzz commented 11 months ago

Working fine here, did you start your server with authlib-injector??

2023-03-31_06 05 51

Personal 1.12.2 Server, skins also fine on my 1.19.3 Server, both started with authlib-injector 1.2.2 but also worked with 1.2.1

The problem is that skins don't show up in servers that don't use authlib-injector, in launchers like Legacy launcher(TL Legacy) the ely by skin system works on every server, but in PollyMC it only works with servers that use authlib-injector or singleplayer worlds

z0mb1e1fy commented 9 months ago

Why is that the case for TL Legacy?

evan-goode commented 9 months ago

I think this is essentially the same issue as https://github.com/fn2006/PollyMC/issues/107. That issue is for PollyMC's "offline accounts", but if you launch the game with an Ely.by account and connect to an online-mode=false server, skins will behave the same as if you launched with an offline account.

Why is that the case for TL Legacy?

See my comment https://github.com/fn2006/PollyMC/issues/107#issuecomment-1807272998