search

fn2006 / PollyMC

DRM-free Prism Launcher fork with support for custom auth servers.
GNU General Public License v3.0
754 stars 48 forks source link

Add PollyMC Flatpak xdg-data access #83

Open lrprawira opened 1 year ago

lrprawira commented 1 year ago

Role

PollyMC Flatpak

Suggestion

Maybe we should add --filesystem=xdg-data/PollyMC:create to the default flatpak args?

Benefit

Use the same directory as non-flatpak PollyMC (e.g. AppImage) data directory which resides at ~/.local/share/PollyMC.

This suggestion is unique

You may use the editor below to elaborate further.

No response

ghost commented 10 months ago

How do you even install the flatpak anyway, can't seem to do it from the terminal and everything online pertains to using a GUI that I funny enough don't have installed.

fn2006 commented 9 months ago

I tried this and it worked fine but is this "correct"? None of the other programs I have installed via flatpak do this, they all use ~/.var/. My main worry is that this might cause issues on immutable systems.

How do you even install the flatpak anyway, can't seem to do it from the terminal and everything online pertains to using a GUI that I funny enough don't have installed.

You literally just run flatpak install <flatpak>. For instance if you downloaded 7.2 to your downloads folder you'd run cd ~/Downloads/ then flatpak install PollyMC-Linux-7.2-x86_64.flatpak.

lrprawira commented 9 months ago

I tried this and it worked fine but is this "correct"? None of the other programs I have installed via flatpak do this, they all use ~/.var/. My main worry is that this might cause issues on immutable systems.

Not sure about the best practises but immutable systems should not reset its home directory outside of .var directory. Some Flatpak apps do do this. us.zoom.Zoom creates both ~/.zoom and ~/Documents/Zoom.

If we omit the :create part, it should also still work for both the existing system install ~/.local/share/PollyMC and flatpak ~/.var/app/org.fn2006.PollyMC/data/PollyMC.