Refactor: Change grades data type from u32 to f32

fnabinash / rust-practice

Collection of 240+ Exercises to learn and practice building CLI tools in Rust

MIT License

151 stars 21 forks source link

Refactor: Change grades data type from u32 to f32 #21

Closed unpeturbed closed 1 month ago

unpeturbed commented 1 month ago

This pull request changes the data type for grades from u32 to f32 to allow for greater precision, particularly when working with fractional grade values.

Reason: The current implementation uses u32 for grades, which restricts the precision to whole numbers. To support fractional grades and improve accuracy in calculations, f32 is more appropriate.

Changes Made:

Updated the grades field from u32 to f32 in: src/main.rs
Adjusted all related calculations and logic to handle f32.

fnabinash commented 1 month ago

Did you push it -f?

If yes, please pull all the changes first then refactor it and raise a pr again.

unpeturbed commented 1 month ago

Did you push it -f?

If yes, please pull all the changes first then refactor it and raise a pr again.

Not sure I get what you mean

fnabinash commented 1 month ago

While you are pushing code did you use the -f(means with force command)?

Because I made some changes to this repo, I hope you did not pull the changes.

Before pulling you pushed your code to the main branch and it failed then you again did it with force(-f).

If yes, please pull the changes first then raise the pr again. Because it rewrites the history.

unpeturbed commented 1 month ago

While you are pushing code did you use the -f(means with force command)?

Because I made some changes to this repo, I hope you did not pull the changes.

Before pulling you pushed your code to the main branch and it failed then you again did it with force(-f).

If yes, please pull the changes first then raise the pr again. Because it rewrites the history.

I get you. now, i didn't force push. I'll try to rectify here anyway