search

fnagel / beautyofcode

TYPO3 CMS Extension beautyofcode
https://extensions.typo3.org/extension/beautyofcode/
GNU General Public License v2.0
6 stars 8 forks source link

Highlighter Mode (Brush Alias) Normalization #6

Closed dreadwarrior closed 10 years ago

dreadwarrior commented 10 years ago

Hi Felix,

I've done some adjustments regarding the Brush Alias normalization due of Library switching (SyntaxHighlighter -> Prism, or the other way around).

This changeset introduces a sophisticated Highlighter structure to cleanly distinguish between different Syntax highlighting libraries - now and in the future.

Best,

tommy

fnagel commented 10 years ago

Hey Tommy,

I've tested these changes and it seems the issues we discussed (switching highlighter engine and *-extra languages in BE select) are fixed. The language fallback mechanism works really nice so far.

Please see my inline code comments.

Yours Felix

fnagel commented 10 years ago

ps: should we release a 2.0.1 soon? Seems adequate to me. What do you think?

dreadwarrior commented 10 years ago

Aloha Felix!

Thanks again for your valuable and detailed review and feedback. I highly appreciate it! I fixed the issues and left a small explanation about the decision to use a "Programming against Interfaces" approach for the HighlighterConfiguration structure as a whole and the brush mapping feature in detail.

I think we are ready to release. This small but important fix is sufficent and comprehensible for a bugfix release.

Best,

tommy

fnagel commented 10 years ago

https://github.com/dreadwarrior/beautyofcode/blob/b847814a4afc685c25df5dca4278fa38243eb1af/Classes/Highlighter/Configuration.php#L70-L71

Empty lines

fnagel commented 10 years ago

Nice, I think we're good to go.