search

fnagel / generic-gallery

TYPO3 extension: Generic Gallery - One gallery to rule them all!
https://extensions.typo3.org/extension/generic_gallery/
GNU General Public License v3.0
7 stars 12 forks source link

PHP 7.3 / 7.4 support #28

Closed fnagel closed 4 years ago

fnagel commented 4 years ago

Needs testing.

liayn commented 4 years ago

Did not spot any issue with v7.4 by inspecting the whole code manually. It would be nice if you could open the ext up for at least 7.3. Thanks.

fnagel commented 4 years ago

Any experience with 7.3 and / or 7.4 while using it? Or just "by reading"?

liayn commented 4 years ago

Well, I'm about to install it locally with 7.3. But to be very honest: if phpstorm does not complain about anything, chances are very high that everything is in good shape. (At least that's my experience)

so installation would be easier (with composer) if you would allow the PHP version. If any hick-up happens it should be rather easy to fix.

fnagel commented 4 years ago

Well, I'm about to install it locally with 7.3.

Feedback would be highly appreciated!

But to be very honest: if phpstorm does not complain about anything, chances are very high that everything is in good shape. (At least that's my experience)

Yes, in general that is my experience too.

so installation would be easier (with composer) if you would allow the PHP version. If any hick-up happens it should be rather easy to fix.

True that but I always followed the guideline to only release tested stuff. Anyway, I updated the constraints in latest master branch commit. Would be amazing if you could test in order to confirm compatibility.

liayn commented 4 years ago

Thanks. I suggest we close this ticket and I'll create a new one in case a problem pops up.

fnagel commented 4 years ago

@liayn Any feedback on PHP 7.3 so far? I'm about to do a 10 LTS compatibility release and it would be great to include PHP 7.3 support.

liayn commented 4 years ago

it would be great to include PHP 7.3 support.

Well, I this would not only be great, actually I see this as a hard requirement, or better said: PHP 7.4 must be the sole goal.

https://www.php.net/supported-versions.php PHP 7.2 is in sec-fix-only mode and officially dead in 7 months.

So from what I can tell so far I have no issues. But I did not test in every corner. My suggestion: open it up to 7.4 and fix one or the other error in case they pop up.

fnagel commented 4 years ago

Thanks for the feedback! Just released 4.2.0 with PHP 7.3 support.

liayn commented 4 years ago

Nice!