search

fnagel / generic-gallery

TYPO3 extension: Generic Gallery - One gallery to rule them all!
https://extensions.typo3.org/extension/generic_gallery/
GNU General Public License v3.0
7 stars 12 forks source link

[TASK] Set a PHP version dependency #4

Closed liayn closed 8 years ago

liayn commented 8 years ago

Also remove the static version number in composer.json as this is not recommended and is always deduced from the tags of the repository.

fnagel commented 8 years ago

Thanks for the PR!

Just for my curiosity: Is there a special reason for using PHP < 7.1?

liayn commented 8 years ago

Regarding PHP. Do you know by now whether the ext will work with 7.1? I would say no. So I would not declare a compatibility that might not be true. In the end that would cause only frustration by the user

fnagel commented 8 years ago

Do you know by now whether the ext will work with 7.1?

No, no testing with 7.x so far -- that's why I was curious why you added this. I will remove this on merge.

liayn commented 8 years ago

??

liayn commented 8 years ago

I exclude PHP 7.1 explicitly.

fnagel commented 8 years ago

Which includes PHP 7.0 -- did you test that?

liayn commented 8 years ago

I looked at the code and found nothing contradicting. And it's running locally here on my 7.6 installation with PHP7 ;-)

fnagel commented 8 years ago

Good enough for now :-D

Thanks for the info!