search

fnagel / jquery-ui

A fork of jQuery UI: WIP branches, legacy Selectmenu Widget (branch: selectmenu) and an accessible version of jQuery UI Tabs (outdated, branch: tabs accessability)
Other
588 stars 141 forks source link

Selectmenu still displayed when a dialog is closed with "escape" key #296

Open donino opened 11 years ago

donino commented 11 years ago

Hi,

I use a selectmenu widget 1.4.0pre embedded in a jquery UI 1.10.2 dialog. If we close this dialog with escape key when the selectmenu is not collapsed, then the selection list is still displayed, floating on the screen until the user clicks anywhere.

This issue can be reproduced with any browser

Thanks

fnagel commented 11 years ago

If you need a version working with the latest jQuery / UI you should test the jQuery UI Selectmenu branch: https://github.com/jquery/jquery-ui/tree/selectmenu It will (hopefully) released with UI 1.11.0

donino commented 11 years ago

Thank you for the fast response Felix. I have just tried this version but it seems there is a dependency on a future method of the menu widget, i got "uncaught Error: no such method 'instance' for menu widget instance". So i couldn't check if it is fixed in this branch.

Never mind, selectmenu 1.4pre works already very well with jQuery UI 1.10.2, except this minor issue with the escape key in a modal dialog. I just wanted to log it to be sure it could be taken in consideration in a next version

Best regards

fnagel commented 11 years ago

Thanks for your feedback! Please checkout this commit, it should work with 1.10.2: https://github.com/jquery/jquery-ui/commit/5a9a80f86cc7844e7357af834c61cc14431110d1

Sadly I'm not quite sure if I will update this branch if the official versionis releases. I think this will be maintained as a legacy version with support for earlier jQuery UI versions. I will tag this issue and perhaps we'll find a solution. If you are able to provide a tested patch, I will gladly intergrate it!

fnagel commented 9 years ago

Is this issue still valid?