Make comment email optional - Githubissues

fnagel / t3extblog

A record based blog extension for TYPO3 CMS. Easy to use and packed with features (incl. comments, subscriptions for comments and posts, Wordpress like subscription manager, reasonable email sending in FE and BE, GDPR ready, BE modules, Dashboard widgets, RSS, Sitemap, ...). Flexible and powerful!

http://typo3.org/extensions/repository/view/t3extblog

GNU General Public License v2.0

33 stars 19 forks source link

Make comment email optional #226

Closed msollmann closed 4 years ago

msollmann commented 4 years ago

Would it be possible to remove the hard coded "required"/"notEmpty" attribute for the email field in comments? In my opinion it is not required by the GDPR, so it wolud be nice to make it configurable via TS.

fnagel commented 4 years ago

That would need some more changes, doesn't it? Like without email we cannot process subscriptions and need optional validation based on that TS value too. Not sure if there's some more thing to consider.

Would you mind adding a PR for that change? I'm still busy trying to make the extension TYPO3 10 compatible...

Some references: https://github.com/fnagel/t3extblog/blob/master/Resources/Private/Partials/Comment/FormFields.html#L38 https://github.com/fnagel/t3extblog/blob/master/Classes/Domain/Model/Comment.php#L52-L53

msollmann commented 4 years ago

Didn't know that it is so complicated because I do not use the subscribe function. I only changed the model, template and TCA. I am also too busy for doing a substantial modification.

fnagel commented 4 years ago

I'm happy you made it work for your project! Would you mind to share you changes here for anybody else?

In general, it's something to consider and not THAT complicated to accomplish. And you're definitely right, an email address is not really required to comment. Would be a nice minor feature to have. So here is...

What needs to be done:

[x] Add dynamic (optional) required validation for comment email property
[x] Make comment email validation configurable using TS
[x] Add check for email and subscription checkbox incl. form error message
[x] Add template condition for comment email required attribute
[x] Adjust subscription logic

fnagel commented 4 years ago

@msollmann I've created a branch with optional comment email address support.

See https://github.com/fnagel/t3extblog/tree/feature-comment-email-optional

Would you mind testing this?

fnagel commented 4 years ago

Any feedback on this?

msollmann commented 4 years ago

Can not test it because I am using Version 5 on TYPO3 9. Thank you anyway!

fnagel commented 4 years ago

Ahh ok. Thanks for the info. I will do some more tests and merge this to master soon...

fnagel commented 4 years ago

Merged to master. Will be included in next release.