search

fnagel / t3extblog

A record based blog extension for TYPO3 CMS. Easy to use and packed with features (incl. comments, subscriptions for comments and posts, Wordpress like subscription manager, reasonable email sending in FE and BE, GDPR ready, BE modules, Dashboard widgets, RSS, Sitemap, ...). Flexible and powerful!
http://typo3.org/extensions/repository/view/t3extblog
GNU General Public License v2.0
32 stars 18 forks source link

Add slash to regex for category_title #233

Closed tomhatzer closed 3 years ago

tomhatzer commented 3 years ago

Fixes https://github.com/fnagel/t3extblog/issues/230#issuecomment-654723276

fnagel commented 3 years ago

Thanks for the contribution!

Mhh, this will allow using / within the category object url_segment field, correct? Not sure if that is something we want for the category slug field. Slashes are allowed for post_title but this is due to the fact we could include the title mixed with the date as one URL part. This works only as there is a custom mapper to do this.

IMO the category TCA config should replace slashes: https://github.com/fnagel/t3extblog/blob/master/Configuration/TCA/tx_t3blog_cat.php#L183-L185

Can you give me a field value and URL example when this happens in your setup?

tomhatzer commented 3 years ago

Hi @fnagel :) Sure thing, this happens on the blog category overview page and the url is "blog/fachbeitraege". I haven't set this on my own anywhere and don't know where this is coming from 🤷‍♂️ The error message is in this comment here including the path: https://github.com/fnagel/t3extblog/issues/230#issuecomment-654723276

tomhatzer commented 3 years ago

@fnagel I just saw that the migrations from the Typo3 8 to Typo3 9 created a category name blog/fachbeitraege for the url_segment column in the tx_t3blog_cat table. I'll change it to blog-fachbeitraege.

tomhatzer commented 3 years ago

I'll close this as it was a mistake on my side. Thanks for helping out 😁

fnagel commented 3 years ago

Thanks for the feedback!

Do you think this is an issue with the update wizard script? Do we need to adjust something?

It SHOULD remove those slashes, since its using the slug service generate method, see d877c1638e73a5b96470449eeed4249d896c2df1

Did you probably use the migration wizard before this was fixed (before d877c1638e73a5b96470449eeed4249d896c2df1 or 7bee80c15f364dd220f29680bfd83d04004a56f9)?