search

fnagel / t3extblog

A record based blog extension for TYPO3 CMS. Easy to use and packed with features (incl. comments, subscriptions for comments and posts, Wordpress like subscription manager, reasonable email sending in FE and BE, GDPR ready, BE modules, Dashboard widgets, RSS, Sitemap, ...). Flexible and powerful!
http://typo3.org/extensions/repository/view/t3extblog
GNU General Public License v2.0
32 stars 18 forks source link

[BUGFIX] Remove superfluous array markers in where method #252

Closed franzkugelmann closed 2 years ago

franzkugelmann commented 2 years ago

They result in a Doctrine\DBAL\Exception\InvalidFieldNameException with latest composer and TYPO3 10.4.26

fnagel commented 2 years ago

Sorry for the late response. I'm in the process of moving my office and flat...

Thanks for the contribution! :-)

The change was introduced in 590d93b3a6c3ac4d3aa76148913dfa97ca6236a7 with using rector. Is that due to an issue in rector or misconfiguration?

sabbelasichon commented 2 years ago

@fnagel I guess the culprit must be this rector rule here: https://github.com/fnagel/t3extblog/commit/590d93b3a6c3ac4d3aa76148913dfa97ca6236a7#diff-d933a2ad57daa43419b483d3f1ddedaec7aa44933007fead9f9437390f596f4aR56

fnagel commented 2 years ago

Hey @sabbelasichon, thanks for helping out here!

So I should better not skip it? Or should it be skipped in order to prevent this issue from happening again?

Looks like the rule was skipped in the commit but the change has been done anyway. Might be a mistake as I was still playing around with the rector config.