search

fnakstad / angular-client-side-auth

One way to implement authentication/authorization in Angular applications
http://angular-client-side-auth.herokuapp.com/
MIT License
1.63k stars 346 forks source link

Update package.json #22

Closed dirkk0 closed 11 years ago

dirkk0 commented 11 years ago

added transformers and uglify-js.

fnakstad commented 11 years ago

Hi Dirk, and thank you for the pull request :) It looks like the commit only contains updates to package.json... Where's the code that actually uses these libraries?

dirkk0 commented 11 years ago

I don't know - I didn't create any code (yet). I only installed your git and just figured out that I (i.e. your code) needed these libraries that I added manually in the first run.

fnakstad commented 11 years ago

Ah, I see. So, if you want to customize the project for your own purposes you should fork the repo first. That way you have your own isolated branch of the code that doesn't affect what's going on in my branch.

dirkk0 commented 11 years ago

I know and thank you - but if you check out your project on a fresh installation you will see that these libs are missing :-).

fnakstad commented 11 years ago

Well, I tried cloning a fresh copy on a computer I previously hadn't pulled the project to, and everything worked fine after doing a simple npm install. Besides, I'm 100% sure I don't have a "direct" dependency on these libraries. I do see that some of the other libraries I'm using have dependencies on transformers and uglify-js, however they should be installed recursively by npm. Could I ask you what command you used to install the dependencies?