search

fnando / browser

Do some browser detection with Ruby. Includes ActionController integration.
MIT License
2.45k stars 361 forks source link

Stripe listed as bot #512

Closed Paradoxor closed 3 years ago

Paradoxor commented 3 years ago

Why is stripe defined as a bot? We want to track our stribe webhooks with ahoy tracking since they are using your gem it took a while until I figured out that stripe is on the list. Is there a reason for this? And would it be possible to whitelist the webhooks from that?

Thanks in advance

fnando commented 3 years ago

And would it be possible to whitelist the webhooks from that?

I don't see a problem with that. In the meantime, you can tweak the list by adding the matching string to Browser::Bot.bot_exceptions or removing Stripe from Browser::Bot.bots with Browser::Bot.bots.delete("stripe").

Paradoxor commented 3 years ago

Yes we have remove Stripe from the list. The question is why is a payment provider like stripe on that list but PayPal not?

Thanks for your answer.

fnando commented 3 years ago

Fixed by https://github.com/fnando/browser/pull/513