search

fnando / browser

Do some browser detection with Ruby. Includes ActionController integration.
MIT License
2.44k stars 358 forks source link

Publish unreleased changes #541

Closed aduth closed 4 months ago

aduth commented 8 months ago

Description

There are a couple changes slated for release (see CHANGELOG.md) which have been merged for multiple years. We particularly have an interest in using the new chromium_based? method. Would you please consider publishing a new release containing these changes?

How to reproduce

require 'browser'
Browser.new('some user agent').chromium_based?

What do you expect

false

What happened instead

undefined method `chromium_based?' for #<Browser::Unknown ...> (NoMethodError)

Software:

aduth commented 8 months ago

I think a workaround given the current implementation is:

browser.chrome? || browser.edge?

On that note, there may be other browsers that should also be considered as Chromium based? Being able to use the chromium_based? abstraction would be preferable to checking individual browsers to allow for changes over time.

fnando commented 4 months ago

just released v6.0.0.

aduth commented 4 months ago

Thank you for releasing the new version! And for maintaining this useful gem ❤️