add spec for inline localization

fnando / i18n-js

It's a small library to provide the I18n translations on the Javascript. It comes with Rails support.

MIT License

3.77k stars 520 forks source link

add spec for inline localization #569

Closed RWOverdijk closed 4 years ago

RWOverdijk commented 4 years ago

Tried sticking to the code style (double quotes and odd comma placement and such). 😄

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 659

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 68.519%

Totals
Change from base Build 655:	0.0%
Covered Lines:	296
Relevant Lines:	432

💛 - Coveralls

PikachuEXE commented 4 years ago

Thanks! I will try to implement it tomorrow or next week... You can try to implement it too 😄

TravisBuddy commented 4 years ago

Hey @RWOverdijk, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 2dcaaf70-a0c9-11ea-8dbc-21d9b9d6c42b

RWOverdijk commented 4 years ago

@PikachuEXE I gave it a go and update the PR. Basically I just pass on the options to the lookup.

PikachuEXE commented 4 years ago

refix indentation

2nd line also indented (return this.toPercentage(value, options);)

PikachuEXE commented 4 years ago

And please also squash the commits

RWOverdijk commented 4 years ago

GitHub can do that nowadays I think?

RWOverdijk commented 4 years ago

Anyway, done.