search

fnar / minecraft-roguelike

This is a mod for minecraft that adds randomly generated dungeon complexes.
GNU General Public License v3.0
14 stars 9 forks source link

(1.12) Endless cascading world gen in Simple Void World #86

Open NostalgicLorikeet opened 8 months ago

NostalgicLorikeet commented 8 months ago

When going to the void world from the Simple Void World mod while having this mod installed, it will attempt to endlessly try and fail to generate dungeons, causing so much cascading world gen lag that the world completely freezes and the game cannot be exited without crashing. Probably related to the fact that the void world is not a unique biome but just a completely empty plains.

NostalgicLorikeet commented 7 months ago

Btw, this could probably be fixed by adding a dimension check to generateInChunkIfPossible() in Dungeons.java.

NostalgicLorikeet commented 7 months ago

Something like this maybe, haven't figured out how to compile to check though :(

    if (editor.getDimension()!=0) {
      return;
    }

Alternatively, it could check for the dim ID of the void world, which is 43 by default but is usually accessed by me.modmuss50.svw.Config.dimID in SVW's source code

    if (editor.getDimension()==43) {
      return;
    }