Closed DonaldTrump88 closed 6 years ago
Yes I thought about #PRAGMA ONCE
but it works fine for all target platforms. Of course we can replace it with #ifndef __SOURCE_NAME__
- I'll do it if I have time.
What do you mean 'Titlecase' and 'BLOCKCASE'? Caps? Please provide an example
Yes
#ifdef __ANDROID__
is better then
```c++
#ifdef __APPLE__
#else
#endif
in case if we add e.g. Windows Phone or any other third platform. But also let's change it. It's more clever to change it - you're right.
Include paths are correct. You need to specify them in your Xcode build settings and Android.mk file. What header can't be found?
You mean in every source in AndroidUtil
dir add
#ifndef __ANDROID__
#pragma error("Android file without __ANDROID_ preprocessor directive.")
#endif
? If so iOS won't compile and reverse. Android- and iOS- Utils are designed to exist on different platform cause in this case developer can add using android::widget::ListView
or using namespace android
without #ifdef
. It is more comfortable. The goal of mitsoko framework is to make a comfortable tool for building crossplatform apps with C++.
No. It's fine. All classes exist on every platform in runtime but their body is included in #ifdef
directives. It allows you to write using java::lang::String
without #ifdef
It would be great to erase #ifdef
for developers cause this feature is ugly.
#ifndef Disposable_h, BLOCK CASE #ifndef DISPOSABLE_H
LOCAL_C_INCLUDES := $(LOCAL_PATH)/../../../../../Core/ \
$(LOCAL_PATH)/../../../../../Core/libs/
What is the expected include path directory containing ViperGod.hpp?
#ifdef __ANDROID__
//all include statements and code.
#endif
ViperGod.hpp
is located at Core/Mitsoko
. So #include "Mitsoko/ViperGod.hpp"
must work.using namespace android
without #ifdef __ANDROID__
I feel that ViperGod.hpp is in include folder. Or folder which has ViperGod.hpp should be used as include folder. Avoiding Mitsoko infront of will avoid adding one more level. It should be like "#include "ViperGod.hpp". There are some places where you refered some includes using path relative root path and current path.
Example: AndroidUtil.hpp
#include "Mitsoko/Util.hpp" //root path
#include "java/lang/Array.hpp" //current path
You are right.
1 and 2 are done. Check pull request.
Added changes for 3. Check pull request.
The remaining point.
#ifdef __ANDROID__
#elif __APPLE__
#endif
Of course you can fix it - this thing will be required once some third platform appears in Mitsoko framework (e.g. Windows Phone). If you want please fix it but we need to test it first before commiting cause I have working apps that pull mitsoko core on every update
I do not need it. But I can fix it once I get this code running.
Ok cool. Please go forward
hey. Is the issue still alive?
closed
I started process to build the library.
will be better.