search

fnc12 / sqlite_orm

❤️ SQLite ORM light header only library for modern C++
GNU Affero General Public License v3.0
2.27k stars 313 forks source link

Quick Check Pragma Test #1291

Closed jakemumu closed 4 months ago

jakemumu commented 4 months ago

Add missing unit test

trueqbit commented 4 months ago

This doesn't run, because the quick_check has not yet been included in the amalgamated .h file which the tests rely on -- I don't see a target to build it, is there a script somewhere in the repo to run?

Thanks @jakemumu for taking care of this! See the contribution guide.

jakemumu commented 4 months ago

Cool, done! PR template file would be nice as well : ) -- thanks @trueqbit

fnc12 commented 4 months ago

let's wait for @trueqbit approve before merging just in case

jakemumu commented 4 months ago

Ahh one more note -- I looked at this file for contributions which is how I missed the amalgamation step:

https://github.com/fnc12/sqlite_orm/blob/dev/CONTRIBUTING.md