search

fncnt / vncnt-hugo

a simple theme for hugo.
MIT License
66 stars 33 forks source link

Restore hard line break #11

Closed davidcoe closed 4 years ago

davidcoe commented 4 years ago

It looks like the renderer was changed in Hugo 0.60.0 to be CommonMark compliant. The previous hard line break needs to be updated to (sortof?) match the CommonMark hard line break.

This is currently broke on the Demo Site linked from the theme directory.

PR#11

fncnt commented 4 years ago

Nice catch, thanks! Would you mind adding a second commit to your PR to apply this exact same change to exampleSite/config.toml? Then I'd be happy to merge your PR.

When the folks over at Hugo fetch themes to build their demo-site directory, they actually rebuild from this directory. I just prefer to have a copy of the demo config file at the root of my repository. It might take a while until they refetch themes, though.

fncnt commented 4 years ago

Also, while you're at it, you could bump the minimum version in theme.toml to min_version = "0.41". That would be great!

fncnt commented 4 years ago

Sorry, I didn't think of it earlier...

davidcoe commented 4 years ago

Also, while you're at it, you could bump the minimum version in theme.toml to min_version = "0.41". That would be great!

That's the version I see unless I'm missing something: https://github.com/davidcoe/vncnt-hugo/blob/51fe228fcb52648ff45645efac93f81f0e3c4f54/theme.toml#L11

davidcoe commented 4 years ago

Nice catch, thanks! Would you mind adding a second commit to your PR to apply this exact same change to exampleSite/config.toml? Then I'd be happy to merge your PR.

When the folks over at Hugo fetch themes to build their demo-site directory, they actually rebuild from this directory. I just prefer to have a copy of the demo config file at the root of my repository. It might take a while until they refetch themes, though.

Didn't even notice it! 51fe228

fncnt commented 4 years ago

Also, while you're at it, you could bump the minimum version in theme.toml to min_version = "0.41". That would be great!

That's the version I see unless I'm missing something: https://github.com/davidcoe/vncnt-hugo/blob/51fe228fcb52648ff45645efac93f81f0e3c4f54/theme.toml#L11

Yeah right, that was a copy-and-paste typo. Of course I meant 0.60.

davidcoe commented 4 years ago

Also, while you're at it, you could bump the minimum version in theme.toml to min_version = "0.41". That would be great!

That's the version I see unless I'm missing something: https://github.com/davidcoe/vncnt-hugo/blob/51fe228fcb52648ff45645efac93f81f0e3c4f54/theme.toml#L11

Yeah right, that was a copy-and-paste type. Of course I meant 0.60.

Thanks for the catch! 9588e69

fncnt commented 4 years ago

No big deal, really! Thanks again.

davidcoe commented 4 years ago

Thank you for the great theme!