feature: Add linkedin and telegram links

fncnt / vncnt-hugo

a simple theme for hugo.

MIT License

66 stars 33 forks source link

feature: Add linkedin and telegram links #4

Closed mikegsrv closed 5 years ago

mikegsrv commented 5 years ago

Hello Vincent!

Found your theme highly attractive, but had to add some extensions for it to fit my demands.

I propose this PR in order to add more relevant contact links for me. I'm working on dynamic extend based on config, however it make take awhile.

Feel free to review.

Have a nice weekends!

Mike

UPD: According to this comment I've added randomize parameter which explicitly limits icon set to 5 and allows to load them dynamically. It removes extraneous icons right after page loads.

fncnt commented 5 years ago

Thanks a lot! I'm going to close this, though. See #2 for an explanation. But, as I outlined in README.md, my approach sorts the links lexicographically according to their keys. I'd be happy to accept a PR that respects the key order in config.toml if it doesn't add a ton of complexity.

mikegsrv commented 5 years ago

@fncnt, hello!

Thanks for reply.

I'll check what I can do with that and get back with results. :)