search

fnichol / knife-server

A Chef Knife plugin to manage Chef Servers. Bootstrap a new Chef Server on Amazon's EC2, Digital Ocean, Linode, OpenStack or a standalone server. Backup and restore your Chef Server or Hosted Chef's node, role, data bag, and environment JSON data.
http://fnichol.github.com/knife-server
Apache License 2.0
158 stars 34 forks source link

Identity fix #15

Closed erikh closed 11 years ago

erikh commented 11 years ago

This fixes bug #14 -- ran into this doing chef-workflow stuff.

Basically, if you're able to pass a nil to net-ssh's keys array, it barfs trying to coerce it to a string. Probably should be fixed upstream but net-ssh... yeah :)

Anyhow, I also fixed the tests where I assumed nils would be ok. Working fine after the fix for my use cases.

If you could release after this one, that'd be great -- basically if you don't supply the argument, it exhibits this error -- passing any non-nil argument works for now, but it's rather confusing for people who don't know what's going on.

fnichol commented 11 years ago

That's a good catch, thanks @erikh!