Feature/nil default options

fnichol / knife-server

A Chef Knife plugin to manage Chef Servers. Bootstrap a new Chef Server on Amazon's EC2, Digital Ocean, Linode, OpenStack or a standalone server. Backup and restore your Chef Server or Hosted Chef's node, role, data bag, and environment JSON data.

http://fnichol.github.com/knife-server

Apache License 2.0

158 stars 34 forks source link

Feature/nil default options #48

Closed dldinternet closed 10 years ago

dldinternet commented 10 years ago

Recreated the pull request after fixing the check.

The idea is to check the configuration values returned and to not set options that don't have default values.

josephholsten commented 10 years ago

This bug effects all providers: EC2, Linode and standalone. It should really be extracted up into a parent or out into a module.

fnichol commented 10 years ago

@josephholsten you nailed it, affected all other knife plugins which 60c68e868c786759c9936b3f10864c1aa8e72f26 should address.

@dldinternet I rebased this PR and merged in into master with b2520f4657497b9ea9d08603c8e4517c5c88d68c . Thank you very much!!