Merge server config to Ec2ServerCreate config

fnichol / knife-server

A Chef Knife plugin to manage Chef Servers. Bootstrap a new Chef Server on Amazon's EC2, Digital Ocean, Linode, OpenStack or a standalone server. Backup and restore your Chef Server or Hosted Chef's node, role, data bag, and environment JSON data.

http://fnichol.github.com/knife-server

Apache License 2.0

158 stars 34 forks source link

Merge server config to Ec2ServerCreate config #8

Closed stormsilver closed 11 years ago

stormsilver commented 11 years ago

Ec2ServerCreate pulls its configs for some items in a way that the options specified on the command line won't get propagated. This is easily fixed by simply merge our config up to the bootstrap object's config.

fnichol commented 11 years ago

Initially I did this to "whilelist" the configuration attributes passed in to Chef::Knife::Ec2ServerCreate but I can't think of any attributes that shouldn't be merged in right now. Your solution will ultimately lead to less CLI-parameter passing bugs. Thank you!