search

fnicollet / Leaflet

:leaves: JavaScript library for mobile-friendly interactive maps
http://leafletjs.com
BSD 2-Clause "Simplified" License
48 stars 20 forks source link

Vector layers are cropped when rotated #1

Open fnicollet opened 8 years ago

fnicollet commented 8 years ago

Following the original issue, there is still one problem with vector rotation, when the map is at zoom 0/1.

We need to backport this fix from @IvanSanchez work https://github.com/Leaflet/Leaflet/commit/a2595bbfe8109dc9cd24a15d28e0e4e6048e2e5f

Transformation is now done using the center and not the topLeft corner which was clamped (calculated in lat/lng).

truongtv22 commented 8 years ago

Can you support for version 0.7.7

fnicollet commented 8 years ago

@hl1994 not possible, too many things related to Leaflet 1.0 which separate layer panes

jeremygbyrne commented 7 years ago

Hi @fnicollet. Loving your work so far, but has there been any progress on getting vector layers to rotate correctly? (My Leaflet project has begun using vector layers extensively, so I've had to stop using the rotation branch.) I'd offer to help, but my JS skills probably aren't up to it.

fnicollet commented 7 years ago

Hello @jeremygbyrne not really any progress on this, sorry. My branch has been merged in the leaflet repo, so maybe one day it will be fully working. It is hard to keep up with the leaflet master changes

Fabien

jeremygbyrne commented 7 years ago

Hi @fnicollet Thanks for the reply! Does that mean the main branch now supports rotation, somehow?

fnicollet commented 7 years ago

Not really, it just means that there is now : https://github.com/Leaflet/Leaflet/tree/rotate While it was on my account before: https://github.com/fnicollet/Leaflet/tree/rotate-master

But both lack updates ...

Fabien

On Mon, Jan 30, 2017 at 3:47 AM, Jeremy Byrne notifications@github.com wrote:

Hi @fnicollet https://github.com/fnicollet Thanks for the reply! Does that mean the main branch now supports rotation, somehow?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fnicollet/Leaflet/issues/1#issuecomment-275969846, or mute the thread https://github.com/notifications/unsubscribe-auth/ABLtoQjyH8xgXJjzUOo4y3ewUqcr3Uxzks5rXU84gaJpZM4JTiY9 .

-- Fabien Nicollet Tel : +33 (0)6 60 54 72 20