search

fnielsen / ordia

Wikidata lexemes presentations
https://ordia.toolforge.org
Apache License 2.0
24 stars 13 forks source link

Feature request: make it possible to add idioms via text to lexeme #189

Open dpriskorn opened 4 months ago

dpriskorn commented 4 months ago

Change select to input field with max two lengh This way I would be able to tune to the number of ngram needed by entering a number.

Try e.g. this Danish proverb input where 10 would be needed: Den der kommer først til mølle, får først malet. Man skal ikke kaste med sten når man selv bor i glashus. Én fugl i hånden er bedre end ti på taget. Tomme tønder buldrer mest. Man skal ikke gå over åen efter vand. Brændt barn skyr ilden. Når katten er ude, spiller musene på bordet.

dpriskorn commented 1 month ago

There is a max-n-gram parameter which might enable what I want https://github.com/fnielsen/ordia/blob/a5286625499ab464de08973128dd6cc66c6e1b05/ordia/app/views.py#L550

dpriskorn commented 1 month ago

This restriction must be removed if idioms and proverbs longer than 3 words are to be curated via text-to-lexemes: https://github.com/fnielsen/ordia/blob/a5286625499ab464de08973128dd6cc66c6e1b05/ordia/app/views.py#L576 @fnielsen

fnielsen commented 1 month ago

This restriction must be removed if idioms and proverbs longer than 3 words are to be curated via text-to-lexemes:

https://github.com/fnielsen/ordia/blob/a5286625499ab464de08973128dd6cc66c6e1b05/ordia/app/views.py#L576

@fnielsen

This was a concern about overloading the server with large max_n_gram.