search

fniessen / emacs-leuven-theme

This Emacs theme reduces eye strain with a light, high-contrast color scheme, syntax highlighting, and support for multiple modes. Enhance your coding experience! #emacs #theme #coding #orgmode
GNU General Public License v3.0
696 stars 59 forks source link

More contrast when highlighting lines #16

Closed wdkrnls closed 9 years ago

wdkrnls commented 9 years ago

I often use hl-line-flash from the hl-line+ package to orient myself in a buffer. I found the default leuven highlight color to be hard to see, so I replaced it with a bright red. Would that be reasonable change to make to the official color scheme, or do you feel strongly about the low contrast yellow?

fniessen commented 9 years ago

Sorry if I don't have that much time to look about it by myself, but why are you using hl-line+ and not just the global-hl-line-mode?

Is hl-line-flash equal by default to hl-line? If yes, I see no objection to give it a different value in my theme.

Regarding your question about my préférences, yes, I'd be strongly opposed to a strong highlighting of the current line (at least for me); I even doubt about using hl-line-mode at all! Even if I still do use it for now...

But be aware that I'm very open to anything that can make my theme more open and/or attractable. Hence, maybe, some customization variables or such...

fniessen commented 9 years ago

I think I've improved the contrast of highlight-line. Though, I'm still interested in your answer to the above.

wdkrnls commented 9 years ago

Looking at the code for hl-line-flash, it just turns on global-hl-line-mode on the current line, waits hl-line-flash-show-period seconds, and turns it off.

dakrone commented 9 years ago

@fniessen I think you recently added the underline to the hl-line correct? Is there a way to turn this off without manually setting the face? The problem is that it makes the underscores in any headline not show up:

With the line not on the headline:

screen shot 2015-05-04 at 2 52 31 pm

With the line on the headline:

screen shot 2015-05-04 at 2 52 24 pm

(Notice that the underscores just don't show up due to the hl-line underline now)

fniessen commented 9 years ago

The above description is correct. It seems to depend, though, on specific fonts and/or specific sizes...

I've sent a bug report to the Emacs maintainers (emacs-bug#20510: Underscore hidden by underline). Wait and see...

I'd like it to be solved, because I like the underline in the current line.

Depending on the outcome, I'll either remove the underline, or add an option to be able to disable it.

dakrone commented 9 years ago

Thanks @fniessen :) judging from the response on the emacs-bugs mailing list, this isn't something that's fixable easily on the Emacs side. Would you be against adding an option to disable it?

fniessen commented 9 years ago

Regarding the underline attribute of hl-line, yep, simply disabled -- though I really think that it'd be a great additon, wouldn't it "remove" the underscores in some fonts / heights.

fniessen commented 9 years ago

@wdkrnls, I improved the contrast of the hl-line by default.

stardiviner commented 6 years ago

I have same question, hope @fniessen can add an option to disable this for a temporary solution.