sx.el colors missing and unreadable

[dakrone]

Colors for sx.el are missing, which causes the headline to show up like:

And makes it really difficult to read the white-on-yellow

[fniessen]

Would you like to come up with a proposition, preferably as a code block which I can directly inject into the theme file, or as a GitHub PR?

[brabalan]

I guess the same colors are used for elfeed:

I have no idea how themes work, however. I had a quick look at the code, and it seems the first step is to find the name of the face that one wants to change. Is it possible through the interface (taking into account the fact that I cannot move the cursor to that point), or can it only be done by looking at the code?

[brabalan]

I’ve looked into this, and both modes use mode-line-buffer-id. Elfeed declares a face for it:

  (defface elfeed-search-filter-face
    '((t :inherit mode-line-buffer-id))
    "Face for showing the current Elfeed search filter."
    :group 'elfeed)

so it can be easily changed, but sx does not:

(defconst sx-inbox--header-line
  '("    "
    (:propertize "n p j k" face mode-line-buffer-id)
    ": Navigate"
    "    "

@dakrone I guess you should file an issue with sx.el asking them to create a face that inherits from mode-line-buffer-id so that the leuven theme could customize it.

[fniessen]

@brabalan Thanks for looking into it.

Your recommandation is clearly the right one! Best regards.

[brabalan]

@fniessen here is some code you could add to the theme for elfeed:

;; elfeed
`(elfeed-search-filter-face ((,class (:foreground "dark gray"))))

(edit: I tried a few variations and a little darker looks better.)

[fniessen]

Pushed.