fniessen / emacs-leuven-theme

This Emacs theme reduces eye strain with a light, high-contrast color scheme, syntax highlighting, and support for multiple modes. Enhance your coding experience! #emacs #theme #coding #orgmode
GNU General Public License v3.0
696 stars 59 forks source link

package lacks a "Version" or "Package-Version" header #4

Closed k69 closed 11 years ago

k69 commented 11 years ago

Please, add version header in leuven-theme.el like there for ability to install your super theme by emacs package system and to add this package to the melpa archive.

fniessen commented 11 years ago

Hello k69. Thanks for your interest in my color theme.

I've already added a version number.

I still need to contribute my package to MELPA, for example (BTW, why that one in particular? I'm not using any package manager yet).

Though, note as well that Emacs Leuven has been added in the "to be" Emacs 24.4 -- it is already in the Emacs 24 dev branch.

Best regards, Fabrice

k69 commented 11 years ago

Hello Fabrice.

Sorry, I made a mistake. It is not a must to have a "Version" header in package, if it will be built by MELPA, because MELPA adds itself generated "Version" header and places initial version to the "X-Original-Version" header if necessary. Problem was in my emacs, package-install-file (emacs function for install package from file, incidentally for check package, that was generated from MELPA recipe, before this recipe will be added to the MELPA on internet) always tells that selected package lacks a "Version" or "Package-Version" header, even if package has a "Version" header. But package-install-from-buffer (which does same as package-install-file, but gets package content from the buffer instead of getting it from the selected file) work well.

And the answer to your question is below. There are two common package managers in emacs:

It is good, that your theme has been added in 24.4. But from MELPA people can get fresh version of it any time.

Thank you for "leuven", for quick and pleasant response. Best regards, Danila.