search

fniessen / emacs-leuven-theme

This Emacs theme reduces eye strain with a light, high-contrast color scheme, syntax highlighting, and support for multiple modes. Enhance your coding experience! #emacs #theme #coding #orgmode
GNU General Public License v3.0
696 stars 59 forks source link

Expected colours for the different org babel blocks? #45

Closed doolio closed 3 years ago

doolio commented 7 years ago

For me, inside an org buffer an org babel quote block does not appear to have the expected background colour. There is also this (IMO ugly) trailing grey/blue line (see below) which takes up the last line inside the block.

ob-quote-blk-leuven-theme

I presume the following is the relevant line of emacs lisp. From this it appears to have the same background colour set as the generic org babel block colours (see screenshot further down) yet the above screenshot suggests that is not the case.

ob-quote-blk-leuven-theme_1

Now if we consider the org babel example block it too does not appear to have the expected background colour. I have the following:

ob-example-blk-leuven-theme

Yet, this following line of emacs lisp suggests I should see a different background colour to both a quote and src block.

ob-example-blk-leuven-theme_1

I presume the following lines of emacs lisp define the generic org babel block colours.

ob-blk-leuven-theme_1

For completeness this is how a src block appears:

ob-src-blk-leuven-theme

Do these screenshots appear as you expect?

Hopefully, you can make out the colours in the above screenshots. I've used rainbow-mode to fontify the colour values in the code. Thanks for leuven and your time.

fniessen commented 7 years ago

Dear Doolio,

Regarding the quote, yes, it's not nice, but this is how it shows as well here. This is a problem which should be reported to the Org mode ML, IMHO.

Regarding the example, I do have the same look as yours. Doing C-u C-x = in there shows that org-example inherits from org-block... while, indeed, it's supposed to be different in my theme. Dunno ATM from where this "new" definition comes... I should investigate, but not much time right now.

Finally, the real src blocks look the same here as well. Sexy!

fniessen commented 3 years ago

Dear @doolio , did you report this to the Org mailing list?

doolio commented 3 years ago

Hi Fabrice, I don't believe I did. I can do so if you like and point here so they can see the screenshots.

fniessen commented 3 years ago

Dear @doolio , I think this could be worth it. Specify your Emacs and Org version.

doolio commented 3 years ago

Fabrice, I've just submitted this bug to the Org mode ML. Apologies for taking so long to get around to this. Some good news perhaps is that the trailing grey/blue line is no longer present in the quote block. I've tested this on Emacs 26.2 and 27.1. Both with Org 9.4.4.

fniessen commented 3 years ago

Would you still show (by testing other themes) that the problem is in Leuven-theme, please let me know. Otherwise, currently, I'll close this request.