search

fniessen / emacs-leuven-theme

This Emacs theme reduces eye strain with a light, high-contrast color scheme, syntax highlighting, and support for multiple modes. Enhance your coding experience! #emacs #theme #coding #orgmode
GNU General Public License v3.0
696 stars 59 forks source link

org src block background in emacs 27 #66

Closed merrickluo closed 4 years ago

merrickluo commented 4 years ago

pre emacs-27, org src block background covers the whole line, but now it seems only text has it.

image
fniessen commented 4 years ago

Dear @merrickluo, thanks for testing and mentioning this. However, this is not related to the Emacs theme, but to the way it's applied within Emacs. So, the problem should be reported to the Emacs team, and maybe (?) also to the Org mode one (on the mailing list, for example).

Best regards!

dakrone commented 4 years ago

I believe this is a breaking change in Emacs 27 where faces now require :extend t to extend past the end of the line. Not necessarily a bug in Emacs.

fniessen commented 4 years ago

Dear @merrickluo , thanks for the context.

I've done what I think should be right. Feel free to test and to give me a feedback.

Best regards!

merrickluo commented 4 years ago

Thanks, @fniessen, and @dakrone, it's working perfectly now! closing issue.

sangwon-hyun commented 3 years ago

Hi! I'm wondering what happened to this fix (the current version -- either on github or on melpa version 1.1.2 -- doesn't have the :extend t anymore.)

My org mode blocks in emacs 27.1 still don't have the coloring extend beyond the line endings.

fniessen commented 3 years ago

Dear @sangwon-hyun ,

That property was finally removed completely from the theme in commit 

afda2d8 Fabrice Niessen        2020-05-13 19:42 +0200 ∙ Apply last changes for integration into Emacs 27

That was asked when pushing a new release of Leuven-theme in the Emacs trunk code - though I don't find the context for that request.

That's not fully clear to me ATM either, but I've seen that my theme does work correctly with org-plus-contrib. I guess you don't have that.