search

fniessen / emacs-leuven-theme

This Emacs theme reduces eye strain with a light, high-contrast color scheme, syntax highlighting, and support for multiple modes. Enhance your coding experience! #emacs #theme #coding #orgmode
GNU General Public License v3.0
696 stars 59 forks source link

Yellow text on white background is unreadable #75

Closed tillydray closed 4 years ago

tillydray commented 4 years ago

Screen Shot 2020-10-26 at 14 32 41

I'm sure this isn't intentional, ~unfortunately I'm not sure what package causes that yellow text. Is there a way for me to find out?~ I believe it's tide, as in Typescript IDE.

EDIT: Just to clarify, I'm talking about the yellow text on the right side of the screenshot

fniessen commented 4 years ago

Dear JasonMFry, not such a thing is not intentional... But I dunno tide...

Can you do C-u C-x = to find out the name of the face in question, and eventually propose a color for it?

tillydray commented 4 years ago

I use Doom Emacs in case that's relevant here. It's either:

The following two faces have the same yellow on white:

I propose all 5 of those faces have #FFF68F background with #000000 text image

This is the same as popup-summary-face, but I like it because yellow is usually a warning or information, and if these 5 faces are trying to convey information or a warning, we should keep yellow, but to make it accessible the font should be black. I think this would work on both light backgrounds and dark backgrounds