fniessen / emacs-leuven-theme

This Emacs theme reduces eye strain with a light, high-contrast color scheme, syntax highlighting, and support for multiple modes. Enhance your coding experience! #emacs #theme #coding #orgmode
GNU General Public License v3.0
696 stars 59 forks source link

Agenda font-color of "WAIT" is dark black #83

Closed herop closed 3 years ago

herop commented 3 years ago

I just recently came to enjoy your theme veeery much I must admit. Contrary to your screenshot, my agenda WAIT looks very different. Please help me out here?

Thank you in advance and kudos for your wonderful theme that is about to become my standard!

Screenshot from 2021-03-18 19-40-38

fniessen commented 3 years ago

Dear @herop , WAIT is not an official Org keyword. I've done it mine, in my Org config. See https://github.com/fniessen/emacs-leuven/blob/e89e409fd1598688fe3a233d06fc627aca15f436/emacs-leuven-org.el#L462 and following lines... PS - I'd advice you to keep all your keywords 4-char long, to get a perfectly aligned screen!

herop commented 3 years ago

Can't thank you enough for your immediate and - as expected - perfectly working advice! Will change any keyword to 4 chars. Very good advice indeed! One more thing: Screenshot from 2021-03-19 12-02-35 Since this is barely recognizable as a green badge with a t in it, I did some digging and found, that moving the mouse over it would make it appear. Any idea why this might happen? Thank you in advance for your reply and have a wonderful day, Jochen

herop commented 3 years ago

I'm near certain you don't want to hear ever of me again. :-)

But this time I have good news: This might be true after all. I fixed my WAIT color issues with this minimal snipped from your config: Screenshot from 2021-03-19 20-17-32 Punched in a (after! org ... ) and - boom, it works. Thank you again for your truly outstanding theme - the only true winner of light themes! Kind regards, Jochen

fniessen commented 3 years ago

Cool you got it!

PS - Not sure to understand your post with the green badge. Make a new issue, if there really is an issue.

PPS - I'm using powerline-leuven-theme.

PPPS - I'm planning to build a course on tips and tricks to boost your Emacs productivity. Would that interest you?

herop commented 3 years ago

1) Not enough to bother you ☺️ 2) Your comment on the powerline theme I didn't get 3) Absolutely

herop commented 3 years ago

Got it reg. Powerline theme ☺️ Just failed to implement it. 😳 You see an easy way to help me out here? Your config is very nice and quite extensive, but I couldn't figure it on myself. Maybe I don't need it? Or would you see big benefits?

fniessen commented 3 years ago

@herop See https://github.com/fniessen/emacs-leuven/blob/e89e409fd1598688fe3a233d06fc627aca15f436/emacs-leuven.el#L1506 and following lines...

herop commented 3 years ago

I know, I know... Status:

What you say?

Thank you so much for all your work and support. I just won't use another theme 'cause I'm such a fan!

Kind regards, Jochen

fniessen commented 3 years ago

Dear @herop, I don't know Doom. I'd say: try with my emacs-leuven config, to see what you're getting. And, depending on the output, you could have hints on where/how to debug your problem.

Best regards!

herop commented 3 years ago

Thank you - again for your immediate help! I do not have a problem, it's just - cosmetics.

You mean the complete config?

I already use the mentioned part. Well, if you could tell me how to change the dark blue (refer to the screenshot above) value in something like light orange, I would just as happy. (Digging and digging, I couldn't find the matching color-code in the source.)

What u say? Best regards, Jochen

fniessen commented 3 years ago

Yes, I meant the whole config.

But, for your question, see face "mode-line" in the theme.

herop commented 3 years ago

Knew it, you would deliver. Thank you so much!! Found the mode-line and punched in an extremely aggressive orange. Now, you made me - again - an incredibly happy Emacs-User (and leuven fan).

Tried to find any theme, but none is even close.

Allow me to sponsor your amazing work with a small sum. (On it)

One more thing: using your config won't work with me I think, since I'm a DOOM user with evil-mode. But will definitely steal some more of your great ideas...

herop commented 3 years ago

defface is a wonderful tool but won't work for me. Can you pls. provide more details? Changing *.el isn't the best idea, right:

(defface mode-line '((t (:box (:line-width 1 :color "#1A2F54") :foreground "green" :background "DarkOrange"))) "Orange and green colors in mode-line.") Can you please tell me, why this is not working even though this does: (setq org-todo-keyword-faces '(("WAIT" . leuven-org-waiting-for-kwd))) ;; Mode-line colors ;; Org non-standard faces. (defface leuven-org-waiting-for-kwd '((t :weight bold :box "#89C58F" :foreground "#89C58F" :background "#E2FEDE")) "Face used to display state WAIT.")

fniessen commented 3 years ago

Dunno if that could be the explanation, but don't expect to change a defface definition, and see the change immediately, even after C-x C-e (after the last parenthesis).

You need to restart Emacs (or, better, launch another instance) to see the results...

herop commented 3 years ago

I did of course. Syncing, restarting ... It doesn't apply at all. Esp. since updates reset any change I make to the original file, I try to find a solution for this. Any further advice?

fniessen commented 3 years ago

Re-reading this whole thread (which deviates a lot from the original subject), I see that:

I guess it's normal: mode-line is defined by standard in Emacs. Though it's not clear from the doc of defface, I guess you can't redefine a face that already exists - that would make sense.

So, if you want to customize it, this must be done via a theme, like mine, or via a customize-face command call, OK?

fniessen commented 3 years ago

Feel free to leave a tip if you enjoy this theme!

(If you have another issue, unrelated to the original one here, please submit a new one.)

herop commented 3 years ago

Just a final note: I did leave a tip of EUR30 on the 19th of April. Hope you received it? Thanks again for your wonderful work and have a great day

fniessen commented 3 years ago

Dear Jochen, yes I did get it. Highly appreciated!