Fixed controlled component issue on last_name.

praveenscience commented 4 years ago

Firebase sending undefined as value.
Value checked if undefined, reset to empty string.

Fixes #88

netlify[bot] commented 4 years ago

Deploy preview for footsteps-app ready!

Built with commit 2e1fd5a8858d580595266e35a96db0018d517b51

https://deploy-preview-103--footsteps-app.netlify.com

praveenscience commented 4 years ago

@xlogix and @R3l3ntl3ss I would have been more inclined to use:

first_name: firebase.auth().currentUser.displayName.split(" ")[0] ?? "",
last_name: firebase.auth().currentUser.displayName.split(" ")[1] ?? "",

But not sure if everyone knows the new ES 2020 syntax, so I reverted back to:

first_name: firebase.auth().currentUser.displayName.split(" ")[0]
  ? firebase.auth().currentUser.displayName.split(" ")[0]
  : "",
last_name: firebase.auth().currentUser.displayName.split(" ")[1]
  ? firebase.auth().currentUser.displayName.split(" ")[1]
  : "",

fnplus / footsteps-app

Fixed controlled component issue on last_name. #103