Adding regex for text field

fnplus / footsteps-app

A search 🔎 engine of experts-led learning paths. Learn by following the footsteps (journey) of experts. 👨‍💻👩‍💻

https://www.footsteps.dev/

GNU General Public License v3.0

42 stars 72 forks source link

Adding regex for text field #142

Closed shreyakapoor08 closed 4 years ago

shreyakapoor08 commented 4 years ago

Fix #79

netlify[bot] commented 4 years ago

Deploy preview for footsteps-app ready!

Built with commit 8a90abd69f16f6a105fcd61175a9f7a8028ca440

https://deploy-preview-142--footsteps-app.netlify.app

xlogix commented 4 years ago

Is this working perfectly for all fields? Have you checked thoroughly? Does the URL validator accept this link? https://twitter.com/hello_world

pydevsg commented 4 years ago

@shreyakapoor08 please do the necessary said by @xlogix so that we can merge your PR, if you need any help feel free to reach out.

xlogix commented 4 years ago

@shreyakapoor08 Any updates? I can merge as soon as you verify

shreyakapoor08 commented 4 years ago

Hi, sorry. I will confirm you about the same by today evening

shreyakapoor08 commented 4 years ago

Is this working perfectly for all fields? Have you checked thoroughly? Does the URL validator accept this link? https://twitter.com/hello_world

Yes I have checked it, the URL validator was not working properly..I have corrected that too. You can check now

xlogix commented 4 years ago

Great @shreyakapoor08. One more thing, instead of showing an alert, can we instead show an error on the text field itself? Maybe shake the text field?

shreyakapoor08 commented 4 years ago

Okay I will do that

shreyakapoor08 commented 4 years ago

@xlogix Kindly check

xlogix commented 4 years ago

Merged!

shreyakapoor08 commented 4 years ago

Kindly consider changing the difficulty label of this PR as it involves writing logics 😊 @xlogix

xlogix commented 4 years ago

Done