fnplus / footsteps-app

A search 🔎 engine of experts-led learning paths. Learn by following the footsteps (journey) of experts. 👨‍💻👩‍💻
https://www.footsteps.dev/
GNU General Public License v3.0
43 stars 72 forks source link

Add Style Guide for Best Practices, Coding Guidelines #47

Open xlogix opened 4 years ago

huonggiangbui commented 4 years ago

I am interested in this issue. Can you @xlogix tell me more specific description about what I have to do and what expected to be? Thanks!

xlogix commented 4 years ago

@huonggiangbui We want to add issue templates, PR templates & style guides for the code. Check out Oppia project for reference. https://github.com/oppia/oppia/

tarun-nagpal-github commented 4 years ago

@xlogix

I have added the react style guide in the Wiki Page.

People can follow that to write better code into React. Below is the link as well.

https://github.com/airbnb/javascript/tree/master/react

xlogix commented 4 years ago

Hey Tarun, thanks for linking the guidelines but I think we should directly add a page with the guidelines and add a source link at the bottom.

Also, did you take a look at issue templates? Or Pull request templates? We could add those too

tarun-nagpal-github commented 4 years ago

Sure @xlogix , I will create a page for the guidelines.

I am working on the other two.

suntwalriya commented 4 years ago

Is this issue assigned to someone, or can I work on it?

xlogix commented 4 years ago

@carrisunrio Go ahead!

tarun-nagpal-github commented 4 years ago

@xlogix @carrisunrio

I have added the WIKI page for "React Style guide and best practices"

https://github.com/fnplus/footsteps-app/wiki/React---Style-guide-and-best-practices