search

fnplus / footsteps-app

A search 🔎 engine of experts-led learning paths. Learn by following the footsteps (journey) of experts. 👨‍💻👩‍💻
https://www.footsteps.dev/
GNU General Public License v3.0
42 stars 72 forks source link

Code Refactoring and Reduce Redundancy in several files #68

Open prajwal714 opened 4 years ago

prajwal714 commented 4 years ago

Make separate stateless/stateful function modules for frequently used React components. Separate JS file for validation function, also unified naming conventions of all the CSS files imported. Components/Create/addPaths.js Components/EditPath/editPath.js etc

vngarg commented 4 years ago

I can work on this .... I have some doubts -

  1. All the links also need to be changed, as the location of .js files and naming convention of .css files changes ?
  2. I can't understand the last point of changing naming conventions ?
prajwal714 commented 4 years ago

@vngarg The same css file is imported with different names, userStyles, styles etc in different js components. Unify them to a single name.

vngarg commented 4 years ago

@vngarg The same css file is imported with different names, userStyles, styles etc in different js components. Unify them to a single name. ok .. Do I have to change the links also ?

prajwal714 commented 4 years ago

Yes. Change the links too, make sure to find redundancy in other files too.