search

fnplus / footsteps-extension

The companion browser extension for footsteps.dev. The project has been moved to a new repo.
https://github.com/xlogix/footsteps-ext
GNU General Public License v3.0
4 stars 26 forks source link

Addressing Issue Number 12 #13

Closed VarthanV closed 4 years ago

VarthanV commented 4 years ago

I have solved the Issue number 12 that was opened by fetching the title and the description of the website when the extension is clicked under the guidance of @xlogix

VarthanV commented 4 years ago

I have made the necessary changes and returned a json object to the main file

VarthanV commented 4 years ago

No Bro what Abhishek bro said is to extract the data and send it to the backend. I am just learning GraphQL the message is nothing but a div in auth.html to make sure that my logic works . Please specify me what i have to do after extracting the data

arjunmahishi commented 4 years ago

We can merge this once the "message" element is sorted out. (this is assuming the changes are tested and working fine)

VarthanV commented 4 years ago

Content.js is a convention to name the file otherwise we cannot access the dom elements and get data . I have removed the message div I just used it for debugging the data will be returned as JSON to the popup file. If you want to know whether it works i have logged the title and metadata in the console when the site loads we can disable that after you approve the PR.

arjunmahishi commented 4 years ago

@VarthanV Thank you for your contributions!