fnplus / footsteps-extension

The companion browser extension for footsteps.dev. The project has been moved to a new repo.
https://github.com/xlogix/footsteps-ext
GNU General Public License v3.0
4 stars 26 forks source link

Code quality increased. #39

Closed garimasingh128 closed 4 years ago

garimasingh128 commented 4 years ago

Issue that this pull request solves

Closes: #38

Proposed changes

Brief description of what is fixed or changed

Types of changes

Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply

@xlogix kindly review.

xlogix commented 4 years ago

Why closed it?

xlogix commented 4 years ago

@garimasingh128 Thanks for the PR and welcome to Footsteps Project. There are still have some issues left in the PR Quality review. Are you gonna work on those?

garimasingh128 commented 4 years ago

Yes sir, I'll take 1-2 days more. That's why I closed it now.

xlogix commented 4 years ago

Okay. I know you sent another PR for this but for future reference, I just wanna say that you can keep committing on your repo and they will be automatically updated on the PR. A good way to raise PRs is to maintain a branch for every feature you're adding... That way any commit on that branch will automatically be added to the PR and your master branch will be available for other work.