Fn ui port change - Githubissues

fnproject / fn-helm

Helm Chart for Fn

Apache License 2.0

56 stars 24 forks source link

Fn ui port change #15

Closed derekschultz closed 6 years ago

derekschultz commented 6 years ago

Changes default port for fn-ui from 4000 to 80
Fixes incorrect env var for fn-ui, FN_PORT -> PORT
Inherit values for ui service ports in templates instead of hardcoding, and provide the default values in case these are not set in values.yaml (which they are by default, but meh, probably good practice)

derekschultz commented 6 years ago

Er, something changed in the latest Helm cli (2.8.0) causing lint to fail.

helm lint --strict fn
==> Linting fn
[ERROR] templates/: render error in "fn/templates/ui-service.yaml": template: fn/templates/_helpers.tpl:14:40: executing "fullname" at <.Values.nameOverride>: map has no entry for key "nameOverride"

Error: 1 chart(s) linted, 1 chart(s) failed

Will look into this tomorrow.

derekschultz commented 6 years ago

I iterated through every chart in kubernetes/charts with helm lint and all fail when using --strict. I think it's safe to just run the plain ol' lint, so I've removed --strict from the CI test.

derekschultz commented 6 years ago

Reverted removal of --strict flag on lint. Will merge https://github.com/fnproject/fn-helm/pull/16 and rebase.

derekschultz commented 6 years ago

Rebased after @jan-g resolved lint error.