fn routes update -c mutates the image value -- changing the route

[rdallman]

In gitlab by @carimura on Jul 14, 2017, 17:15

this actually mutates the image based on the version that's in func.yaml. This caught be by surprise because I'm not using the func.yaml to set my image, I'm using wercker, and I suspect our users will be using all sorts of versioning strategies, and do not want their route destroyed everytime they do an fn routes update...

[rdallman]

In gitlab by @carimura on Jul 14, 2017, 17:15

changed title from fn routes update -c {-SOMEVAR=SOMEVAL-} to fn routes update -c {+mutates the image value -- changing the route+}

[rdallman]

In gitlab by @carimura on Jul 14, 2017, 17:15

changed the description

[rdallman]

In gitlab by @denismakogon on Jul 17, 2017, 10:32

This is strange, i tried to reproduce on recent master and got this:

fn routes update -c TWITTER_CONF_KEY=123 test /mlog
error: Could not update route - path is immutable

Master branch commit: c6053172502d1a62d1b0ef4a5ba3f453d4903d24

[rdallman]

In gitlab by @carimura on Jul 17, 2017, 12:47

@denismakogon I get that when I'm in the directory where a func.yaml exists for a function, but you're trying to update a different function.... Is that the case for you?

[rdallman]

In gitlab by @denismakogon on Jul 17, 2017, 13:05

Oh, yeah, this happens when i'm trying to update functions that was created from current directory but with different route. Let's say in func.yaml i have /multi-log but route was created with path /mlog. So i'm a bit confused, does CLI parameters mean less than func.yaml?

[rdallman]

In gitlab by @denismakogon on Jul 18, 2017, 05:52

So, the problem appeared in datastore layer, when trying to update route with exact the same attributes datastore layer fails with an error "Route not found" because zero rows in DB were updated. Implementing method that checks if routes were (including all attributes) the same before attempting to update it.

[rdallman]

In gitlab by @denismakogon on Jul 18, 2017, 05:52

mentioned in commit f89c30385d1c5f4658180d95cbfad28d676dd825

[rdallman]

In gitlab by @denismakogon on Jul 18, 2017, 05:53

mentioned in merge request !111

[rdallman]

In gitlab by @denismakogon on Jul 18, 2017, 05:56

mentioned in commit 5d5ff82c9853df926c533f85210a3734f43beef1

[rdallman]

In gitlab by @denismakogon on Jul 18, 2017, 09:19

mentioned in commit 8b565e17453f92f9d86b817eacb93b974039cfe3

[rdallman]

In gitlab by @rdallman on Jul 18, 2017, 13:40

closed via commit 570e9265f16fb4ee16ffdd0bbb7a9e797dd4eeeb

[rdallman]

In gitlab by @rdallman on Jul 18, 2017, 13:40

closed via merge request !111

[rdallman]

In gitlab by @rdallman on Jul 19, 2017, 11:05

mentioned in commit 570e9265f16fb4ee16ffdd0bbb7a9e797dd4eeeb