fnproject / ui

User interface for fn project.
Apache License 2.0
89 stars 21 forks source link

On stacked graphs (completed and failed), fill colours are merged #43

Open nigeldeakin opened 6 years ago

nigeldeakin commented 6 years ago

The fill colours used with stacked charts (i.e. completed and failed) do not match the fill colours shown in the legend.

See this screenshot: screenshot from 2018-02-05 15-36-42

In the "completed" graph, see how the legend shows the path /hello-cold-async-a2 as having a blue fill colour, but the actual fill colour used is a kind of green.

The green colour appears to be caused by the yellow fill extending from Y=30 all the way down to the X-axis, and being combined with the blue colour below Y=20.

This was reported in the following chart.js issues: https://github.com/chartjs/Chart.js/issues/2579 https://github.com/chartjs/Chart.js/issues/2380

The second of these suggests a workaround. This should be applied. If it can't we should reconsider whether we should use a fill colour (and whether these graphs should be stacked at all).