search

fntneves / laravel-transactional-events

Transaction-aware Event Dispatcher for Laravel
MIT License
314 stars 28 forks source link

Dingo Api #16

Closed ethersport-io closed 6 years ago

ethersport-io commented 6 years ago

Hello. After installing the package, I get a conflict: Argument 1 passed to Dingo\Api\Http\Response::setEventDispatcher() must be an instance of Illuminate\Events\Dispatcher, instance of Neves\Events\TransactionalDispatcher given, called in ../vendor/dingo/api/src/Provider/DingoServiceProvider.php on line 37

fntneves commented 6 years ago

Hello,

The problem is that Dingo is expecting the original Event Dispatcher class, not the Event Dispatcher interface.

TransactionalDispatcher implements that interface, rather than extending the Event Dispatcher class. Therefore, it is not compatible with Dingo.

We can solve this by opening an issue in Dingo's repository and see if they can change it. (Sentry also changed it in their driver's code).

Edit: I've opened a PR: https://github.com/dingo/api/pull/1594