fntsrlike / slack-irc-syncbot

Synchronize messages between Slack and IRC.
MIT License
11 stars 4 forks source link

Add `/me` command sync #2

Closed fntsrlike closed 9 years ago

fntsrlike commented 9 years ago

Add /me command sync from both to each other

david50407 commented 9 years ago

There is no /me API on Slack even if you can heard /me from IRC.

fntsrlike commented 9 years ago

Yes, you are right. 2015-02-04 2 30 55

In other way, we can listen /me events from IRC, and output text with Italics. Then we have the same display. 2015-02-04 2 32 05

fkztw commented 9 years ago

ref to this PR https://github.com/fntsrlike/slack-irc-syncbot/pull/13

david50407 commented 9 years ago

why not add the effect in IrcMsgEncoder ?

fkztw commented 9 years ago

you mean like this? https://github.com/NCTU-NBA/slack-irc-plugin/commit/7419fc9aee906c086e011d5c92d4ce3f58c07453

fntsrlike commented 9 years ago

BTW, Maybe we can use slash command interaction to listen /me from slack, and sent message to IRC

fkztw commented 9 years ago

add the effect in IrcMsgEncoder. ref to PR https://github.com/fntsrlike/slack-irc-syncbot/pull/15

fkztw commented 9 years ago

Slash Commands API won't send Slash Commands which are overlapped with those default Slash Commands like /me. Even if you have already set /me into the Slash Commands API to listen on, Slack still sends it via outgoing token not slash commands token. Other commands which are not overlapped with default slash commands are ok to be sent via the slash commands token.