search

fnxweb / urllink

URL Link Firefox and Thunderbird add-on
https://addons.mozilla.org/en-GB/firefox/addon/url-link/
8 stars 0 forks source link

Acknowledge 2018's security standards #11

Closed Eagle3386 closed 5 years ago

Eagle3386 commented 6 years ago

Given that Firefox, Chrome and probably several other browsers discourage accessing non-HTTPS URLs nowadays (especially since Let's Encrypt offers SSL certificates for free), shouldn't we respect this where possible? Like in line 463 of background.js - a possible section or an impossible one?

fnxweb commented 5 years ago

Firefox itself still defaults back to http; I may make this an option, though.

Eagle3386 commented 5 years ago

Looking forward to your implementation! 👍

Eagle3386 commented 5 years ago

Any update on this? :smile:

fnxweb commented 5 years ago

I did start it, got distracted, and forgot all about it!

I'll set a reminder for next weekend…

fnxweb commented 5 years ago

Fixed by commit 310057932c05681576b8185f37e7b84c54b3d8d0

Eagle3386 commented 5 years ago

@fnxweb may I ask for getting attributed as a contributor within the package's release notes or in the manifest, e. g. "and contributors (<list of contributors>)"?

fnxweb commented 5 years ago

Shit, should've thought of that. I'll put it in for the next drop.

You're in the changelog FWIW 😕

Soz.

Eagle3386 commented 5 years ago

And now it's me who needs to apologize - my board and shiny new GPU just died, hence too many (RMA) mails to answer and your GitHub notification just fell through.. :disappointed: Anyway, saw the mention in the changelog. Looking forward to the release note's entry. :wink:

Until then, I feel really honored for finally being mentioned within the extension which accompanies me throughout my whole Firefox-life. In fact, it was pretty much the first one I installed back in the days of Firefox 2.x - just after discovering that browser in general. So, thanks a lot for this special moment, Neil! :+1:

If Firefox for Android will ever support URL Link as an extension (install succeeded, but selected text doesn't offer its options), I'm sure I'll reach heaven.. :rofl:

fnxweb commented 5 years ago

Yeah, I just Android Firefox, and have been mulling how it might work. Things are a little … /different/ … for the version, though.

Soz about the PC 🙁

Eagle3386 commented 5 years ago

Looking forward to such a version, though. :wink:

PC should ok again by the end of next week or at least the week after that - which is acceptable, because I'm flooded with work and I'm on holidays starting next Friday.. :grin: