search

fnxweb / urllink

URL Link Firefox and Thunderbird add-on
https://addons.mozilla.org/en-GB/firefox/addon/url-link/
8 stars 0 forks source link

Added item unavailable until re-enabling extension #15

Open Eagle3386 opened 5 years ago

Eagle3386 commented 5 years ago

Adding a new item under moz-extension://db1d30dc-3f4f-43a1-8b7b-77d1b74edee4/preferences.html -> Edit Menu won't make it available within the context menu afterwards.

Clicking Apply or even restarting Firefox does not resolve the issue either. Only pressing CTRL+SHIFT+A, clicking •••, then Disable, then ••• again and finally Enable let's the newly added item show up.

Is there some way to inform Firefox of changes to an addon's provided context menu entry's sub-entries? Kinda dirty hack, i. e. "disable->re-enable", is either forbidden right away or probably will be in the future.

I'd happily assist in fixing this if I'm pointed in the right direction. :wink:

fnxweb commented 5 years ago

Yeah, I noticed another setting recently that didn't take immediately.

It did all work originally, so there must have been a change under the hood that's borked it. Suspect a threading race condition (it's all asychronous now).

Actually, now I type this, it's likely the [URL Link] message that's sent out internally when prefs are saved to the other bits of the extension so they know that things have changed. If that's now going AWOL it could explain this.