search

fnxweb / urllink

URL Link Firefox and Thunderbird add-on
https://addons.mozilla.org/en-GB/firefox/addon/url-link/
8 stars 0 forks source link

Update Thunderbird version to WebExtensions baseline #17

Open fnxweb opened 4 years ago

fnxweb commented 4 years ago

Thunderbird should now support the latest WebExtensions version of URL Link, so this issue will track updating that baseline code to run on Thunderbird.

Don't hold your breath, it'll likely be a couple of months.

fnxweb commented 4 years ago

As the main Firefox WebExtensions re-write is now frustratingly close to working in Thunderbird, I'll be picking this up as the main way to get URL Link working in TB 78+.

Expect at least a beta release once I have the core working, but it may be a little rough around the edges (e.g., the prefs. dialogue doesn't render the drag handles properly, even though it's all just CSS, and the Changelog link is borked, so I may have to handle that via JS instead of HTML.

fnxweb commented 4 years ago

I have pushed a beta release 3.5beta1 that works with TB 78.2 to the TB add-ons page. I hope it will be flagged as a beta and not be automatically rolled out, even though it seems mostly OK. I don't think you will be able to access it until it's been reviewed, though, and it may fail that if they spot something (or I need another flag somewhere to really make it a beta).

Please report any issues here!

fnxweb commented 4 years ago

Here is a test XPI in advance of the review (for the brave).

urllink-3.5beta1.zip

Rename it to .xpi and install it from the add-ons manager tab.

Duncan-Moore commented 4 years ago

Thanks for getting this working with WE - it's very useful, and hasn't been working for a while. Here's some comments:

1) When an email is viewed in a tab, it works. But when an email is viewed in a separate window, nothing opens when I click on the menu entries. 2) 'Help' says 'You may choose whether URL Link places its option near the top or the bottom of the standard context menu via a preference' but it's not clear how to do this.

I'm not sure if these are bugs or 'just the way it is': 3) When writing an email and text is selected, URL Link doesn't appear in the menu. 4) When the pointer is over emails/folders, URL Link appears on the menu (just Help,Changelog,Preferences) - which seems a bit redundant.

Windows 10 64bit TB 68.12.0 URL Link 3.5

fnxweb commented 4 years ago

Thanks for that, I'd not tested separate windows or compose (although there shouldn't be a difference…).

The help is out of date re: positioning, that can't be changed now. I'll have to update it (dunno how I'll do that for the foreign language help!).

The always-available bit was recent & deliberate, as it's tricky to find the permissions now and I thought it odd you needed to have selection before being able to access those items.

On 4 September 2020 17:52:41 BST, Duncan-Moore notifications@github.com wrote:

Thanks for getting this working with WE - it's very useful, and hasn't been working for a while. Here's some comments:

1) When an email is viewed in a tab, it works. But when an email is viewed in a separate window, nothing opens when I click on the menu entries. 2) 'Help' says 'You may choose whether URL Link places its option near the top or the bottom of the standard context menu via a preference' but it's not clear how to do this.

I'm not sure if these are bugs or 'just the way it is': 3) When writing an email and text is selected, URL Link doesn't appear in the menu. 4) When the pointer is over emails/folders, URL Link appears on the menu (just Help,Changelog,Preferences) - which seems a bit redundant.

Windows 10 64bit TB 68.12.0 URL Link 3.5

-- You are receiving this because you were assigned. Reply to this email directly or view it on GitHub: https://github.com/fnxweb/urllink/issues/17#issuecomment-687266199

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

fnxweb commented 4 years ago

I've found an issue in my context handler for separate windows (possibly caused by a TB bug) for TB versions < 78, so I can make it work in separate windows in the next release (it already does if you have TB 78+).

Unfortunately, it looks like there's another TB bug that prevents add-ons creating context-menu items in the compose window. Unless I can fudge a work-around (or am missing something!), that'll likely have to wait until TB fixes it, but so far as I can see it's not even being looked at yet :(

int-red commented 3 years ago

Firefox Addon https://addons.mozilla.org/en-US/firefox/addon/local-filesystem-links uses a helper application to open local file links.

Could this be implemented for URL Link too?

fnxweb commented 3 years ago

It could but it would require an awful lot of effort to add and maintain such a cross-platform exe. I'll have a dig if I get time to see if it'd be practical to pull this impl. in as an external somehow.