pjlammertyn
commented
7 years ago Adding orderby to the foreach statement in the BuildWalkQueue function of the DicomDatasetWalker class seems to do the trick: dataset.OrderBy(di => di.Tag.Group).ThenBy(di => di.Tag.Element)
private static void BuildWalkQueue(IEnumerable<DicomItem> dataset, Queue<DicomItem> items)
{
foreach (var item in dataset.OrderBy(di => di.Tag.Group).ThenBy(di => di.Tag.Element))
{
if (item is DicomElement)
{
items.Enqueue(item);
}
else if (item is DicomFragmentSequence)
{
var sq = item as DicomFragmentSequence;
items.Enqueue(item);
foreach (var fragment in sq)
{
items.Enqueue(new DicomFragmentItem(fragment));
}
items.Enqueue(new EndDicomFragment());
}
else if (item is DicomSequence)
{
var sq = item as DicomSequence;
items.Enqueue(item);
foreach (var sqi in sq)
{
items.Enqueue(new BeginDicomSequenceItem(sqi));
BuildWalkQueue(sqi, items);
items.Enqueue(new EndDicomSequenceItem());
}
items.Enqueue(new EndDicomSequence());
}
}
}
anders9ustafsson
Actual behavior
The private tag (0019,1153) is listed in the DicomDataSet before tag (0019,1006).
Steps to reproduce the behavior
Use the DicomDump utility and open the attached image. Tag (0019,1153) is listed out of order. Version 2.x the DicomDump utility displays the correct order. Wireshark shows the tag sent out of order when sending the image with DicomClient.
fo-dicom version and OS/platform
3.1 alpha also tested in 3.0.2 with the same result. Windows 10/Desktop
00000001.zip